kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore_evas - fix aninmator based frame render ticking to full framerate 

so i was seeing ecore evas only rendering every 2nd frame... this is
because it was adding and deleting animatiors every time it rendered
instead of keeping one around as lon as updates where there to render
and then remove it afterwards. this caused nasty timing problems and
thus problems assessing framerate of rendered content etc. etc. ...
not good. this fixes that. this only happened if you only used pure
legacy ecore animators. if you used the efl animator tick events it
worked right.

@fix
This commit is contained in:
Carsten Haitzler 2018-11-22 11:45:00 +00:00
parent 6ec6d93535
commit 12827e8873
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/ecore_evas/ecore_evas.c
View File

@ -120,9 +120,6 @@ _ecore_evas_animator(void *data, const Efl_Event *ev EINA_UNUSED)
Ecore_Evas *ee = data;
ee->animator_ticked = EINA_TRUE;
efl_event_callback_del(ee->evas, EFL_EVENT_ANIMATOR_TICK, _ecore_evas_animator, ee);
ee->animator_registered = EINA_FALSE;
}
static Eina_Bool
@ -308,6 +305,11 @@ _ecore_evas_idle_enter(void *data EINA_UNUSED)
if (ee->engine.func->fn_evas_changed)
ee->engine.func->fn_evas_changed(ee, change);
if (!change)
{
efl_event_callback_del(ee->evas, EFL_EVENT_ANIMATOR_TICK, _ecore_evas_animator, ee);
ee->animator_registered = EINA_FALSE;
}
#ifdef ECORE_EVAS_ASYNC_RENDER_DEBUG
if ((ee->in_async_render) && (ee->async_render_start <= 0.0))
{
@ -3284,9 +3286,12 @@ _ticking_start(Ecore_Evas *ee)
{
// Backend doesn't support per window vsync, fallback to generic support
if (ee->animator_count++ > 0) return;
if (!ee->anim)
{
ee->anim = ecore_animator_add(_ecore_evas_animator_fallback, ee);
}
}
}
static void
_ticking_stop(Ecore_Evas *ee)
@ -3304,10 +3309,13 @@ _ticking_stop(Ecore_Evas *ee)
{
// Backend doesn't support per window vsync, fallback to generic support
if (--ee->animator_count > 0) return;
if (ee->anim)
{
ecore_animator_del(ee->anim);
ee->anim = NULL;
}
}
}
static void
_check_animator_event_catcher_add(void *data, const Efl_Event *event)