kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm - genlist item - index get start from 0 - unbreak api break 

so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1
rather than 0. going back to elm code in 1.7 - it started at 0. this
is an api break that shouldn't have happend, but did. this fixes that.
yes - it's inconsistent with gengrid's index_get - but gengrid here is
wrong. nth_get starts at 0. this will get fixed with eo api's, and in
fact none of these index/nth api's should be in genlist's eo api.
legacy only. i can see why this was changed - it matches gengrid and
is more consistent, but we can't break things even if stupid.

@fix
This commit is contained in:
Carsten Haitzler 2016-03-10 18:29:22 +09:00
parent 72fb43d383
commit 1358879201
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
legacy/elementary/src/lib/elm_genlist.c
View File

@ -7333,7 +7333,7 @@ elm_genlist_item_cursor_engine_only_get(const Elm_Object_Item *eo_it)
EOLIAN static int
_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
{
int cnt = 1;
int cnt = 0;
Elm_Gen_Item *tmp;
ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);

2
legacy/elementary/src/lib/elm_genlist_item.eo
View File

@ -170,7 +170,7 @@ class Elm.Genlist_Item(Elm.Widget_Item)
get {
[[Get the index of the item. It is only valid once displayed.
The index start from 1.
The index start from 0.
]]
}
values {