kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests: rework strbuf append/prepend tests 

there's no point in iterating this many times; the base step size is 32
and so each loop will only increase the buffer...not at all since it takes
3 loops for the buffer to increase by the step size

verify that the buffer increases and then stop instead of spinning uselessly

fix T6835

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
This commit is contained in:
Mike Blumenkrantz 2018-03-30 11:11:57 -04:00 committed by Stefan Schmidt
parent 0f3f651f81
commit 1f7f7297e3
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/tests/eina/eina_test_strbuf.c
View File

@ -372,7 +372,7 @@ EFL_END_TEST
EFL_START_TEST(eina_test_strbuf_append_realloc)
{
Eina_Strbuf *buf;
const size_t runs = 40960;
const size_t runs = 3 * 10;
const char target_pattern[] = "stringstrsstr";
const char *str;
size_t i, target_pattern_size;
@ -382,19 +382,19 @@ EFL_START_TEST(eina_test_strbuf_append_realloc)
for (i = 0; i < runs; i++)
{
fail_if(!eina_strbuf_append(buf, "string"));
fail_if(!eina_strbuf_append_n(buf, "string", 3));
fail_if(!eina_strbuf_append_char(buf, 's'));
fail_if(!eina_strbuf_append_length(buf, "string", 3));
ck_assert_int_ne(eina_strbuf_append(buf, "string"), 0); //6
ck_assert_int_ne(eina_strbuf_append_n(buf, "string", 3), 0); //3
ck_assert_int_ne(eina_strbuf_append_char(buf, 's'), 0); //1
ck_assert_int_ne(eina_strbuf_append_length(buf, "string", 3), 0); //3
}
target_pattern_size = strlen(target_pattern);
ck_assert_int_eq(eina_strbuf_length_get(buf), runs * target_pattern_size);
str = eina_strbuf_string_get(buf);
fail_if(str == NULL);
ck_assert_ptr_nonnull(str);
for (i = 0; i < runs; i++, str += target_pattern_size)
fail_if(memcmp(str, target_pattern, target_pattern_size));
ck_assert_int_eq(memcmp(str, target_pattern, target_pattern_size), 0);
eina_strbuf_free(buf);
}
@ -403,7 +403,7 @@ EFL_END_TEST
EFL_START_TEST(eina_test_strbuf_prepend_realloc)
{
Eina_Strbuf *buf;
const size_t runs = 40960;
const size_t runs = 3 * 10;
const char target_pattern[] = "strsstrstring";
const char *str;
size_t i, target_pattern_size;
@ -413,19 +413,19 @@ EFL_START_TEST(eina_test_strbuf_prepend_realloc)
for (i = 0; i < runs; i++)
{
fail_if(!eina_strbuf_prepend(buf, "string"));
fail_if(!eina_strbuf_prepend_n(buf, "string", 3));
fail_if(!eina_strbuf_prepend_char(buf, 's'));
fail_if(!eina_strbuf_prepend_length(buf, "string", 3));
ck_assert_int_ne(eina_strbuf_prepend(buf, "string"), 0); //6
ck_assert_int_ne(eina_strbuf_prepend_n(buf, "string", 3), 0); //3
ck_assert_int_ne(eina_strbuf_prepend_char(buf, 's'), 0); //1
ck_assert_int_ne(eina_strbuf_prepend_length(buf, "string", 3), 0); //3
}
target_pattern_size = strlen(target_pattern);
fail_if(eina_strbuf_length_get(buf) != (runs * target_pattern_size));
ck_assert_int_eq(eina_strbuf_length_get(buf), runs * target_pattern_size);
str = eina_strbuf_string_get(buf);
fail_if(str == NULL);
ck_assert_ptr_nonnull(str);
for (i = 0; i < runs; i++, str += target_pattern_size)
fail_if(memcmp(str, target_pattern, target_pattern_size));
ck_assert_int_eq(memcmp(str, target_pattern, target_pattern_size), 0);
eina_strbuf_free(buf);
}