kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

genlist: Send param item type instead of eo item type. 

Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix

Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Subscribers: SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2136
This commit is contained in:
woochan lee 2015-03-12 15:42:30 +09:00 committed by ChunEon Park
parent 411c30b408
commit 1f8ad27e40
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
legacy/elementary/src/lib/elm_genlist.c
View File

@ -7560,9 +7560,12 @@ _elm_genlist_select_mode_set(Eo *obj EINA_UNUSED, Elm_Genlist_Data *sd, Elm_Obje
(sd->select_mode == ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY))
{
Eina_List *l, *ll;
Elm_Gen_Item *it;
EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, it)
Elm_Object_Item *eo_it;
EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, eo_it)
{
ELM_GENLIST_ITEM_DATA_GET(eo_it, it);
_item_unselect(it);
}
}
}