From 2248e84a4bdae0302a69346b1b6fecbcd6a81534 Mon Sep 17 00:00:00 2001 From: Stefan Schmidt Date: Tue, 25 Feb 2020 10:36:39 +0100 Subject: [PATCH] exactness: inspect: fix memory leak of buffer in error path If we hit this error path we need to release the allocated buffer. CID: 1419878 Reviewed-by: Mike Blumenkrantz Differential Revision: https://phab.enlightenment.org/D11407 --- src/bin/exactness/inspect.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bin/exactness/inspect.c b/src/bin/exactness/inspect.c index 64f5d1760f..7a119034b0 100644 --- a/src/bin/exactness/inspect.c +++ b/src/bin/exactness/inspect.c @@ -357,7 +357,11 @@ _scn_text_get(void *data, Evas_Object *gl, const char *part EINA_UNUSED) Exactness_Action *a1 = vv->p1; Exactness_Action *a2 = vv->p2; - if (!a1 ^ !a2) return strdup("XXXXX"); + if (!a1 ^ !a2) + { + eina_strbuf_free(buf); + return strdup("XXXXX"); + } if (a1->delay_ms != a2->delay_ms) eina_strbuf_append_printf(buf, "[+"LDIFF(%.3f)"/+"RDIFF(%.3f)"]: ", a1->delay_ms/1000.0, a2->delay_ms/1000.0); else eina_strbuf_append_printf(buf, "+%.3f: ", a1->delay_ms / 1000.0);