kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore_file_can_exec: fix .bat case 

the test on the .bat file was too early

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12122
This commit is contained in:
Vincent Torri 2020-08-31 13:46:51 +00:00 committed by Stefan Schmidt
parent b89f1cc0a3
commit 2261332969
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lib/ecore_file/ecore_file.c
View File

@ -643,7 +643,7 @@ ecore_file_can_exec(const char *file)
h = CreateFile(file, GENERIC_READ, FILE_SHARE_READ, NULL,
OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
if (h == INVALID_HANDLE_VALUE)
return EINA_FALSE;
goto test_bat;
if (!GetFileSizeEx(h, &sz))
goto close_h;
@ -697,16 +697,16 @@ ecore_file_can_exec(const char *file)
*/
if ((characteristics & 0x0002) && !(characteristics & 0x2000))
return EINA_TRUE;
unmap_view:
UnmapViewOfFile(base);
close_h:
CloseHandle(h);
test_bat:
/*
* a .bat file, considered as an executable, is only a text file,
* so we rely on the extension. Not the best but we cannot do more.
*/
return eina_str_has_extension(file, ".bat");
unmap_view:
UnmapViewOfFile(base);
close_h:
CloseHandle(h);
#else
if (!access(file, X_OK)) return EINA_TRUE;
#endif