From 23bebb1c4712fbfef06f1439097e3cf12c4e8d0f Mon Sep 17 00:00:00 2001 From: Ryuan Choi Date: Fri, 10 Jan 2014 21:05:00 +0900 Subject: [PATCH] genlist: Check return value out of the loop in _realized_items_get --- legacy/elementary/src/lib/elm_genlist.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/legacy/elementary/src/lib/elm_genlist.c b/legacy/elementary/src/lib/elm_genlist.c index f7d9788aa3..b6d0be36d9 100644 --- a/legacy/elementary/src/lib/elm_genlist.c +++ b/legacy/elementary/src/lib/elm_genlist.c @@ -5952,7 +5952,9 @@ _realized_items_get(Eo *obj EINA_UNUSED, void *_pd, va_list *list) Eina_List **ret = va_arg(*list, Eina_List **); Elm_Genlist_Smart_Data *sd = _pd; - if (ret) *ret = NULL; + if (!ret) return; + + *ret = NULL; EINA_INLIST_FOREACH(sd->blocks, itb) { @@ -5964,7 +5966,7 @@ _realized_items_get(Eo *obj EINA_UNUSED, void *_pd, va_list *list) done = EINA_TRUE; EINA_LIST_FOREACH(itb->items, l, it) { - if (it->realized && ret) *ret = eina_list_append(*ret, it); + if (it->realized) *ret = eina_list_append(*ret, it); } } else