From 2d7667aa44780a5a4136b317d050b65d66da21eb Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Tue, 4 Aug 2020 11:44:13 +0000 Subject: [PATCH] efl_ui_timepicker: Add null check for efl_text_get Prevent null access of the string passed from efl_text_get. Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D12085 --- src/lib/elementary/efl_ui_timepicker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/efl_ui_timepicker.c b/src/lib/elementary/efl_ui_timepicker.c index d66ed0e853..9dfcd89b14 100644 --- a/src/lib/elementary/efl_ui_timepicker.c +++ b/src/lib/elementary/efl_ui_timepicker.c @@ -90,14 +90,14 @@ _field_changed_cb(void *data, const Efl_Event *ev) if (ev->object == pd->hour) { pd->cur_time[TIMEPICKER_HOUR] = efl_ui_range_value_get(pd->hour); - if (!pd->is_24hour && !strcmp(efl_text_get(pd->ampm), "PM")) + if (!pd->is_24hour && eina_streq(efl_text_get(pd->ampm), "PM")) pd->cur_time[TIMEPICKER_HOUR] += 12; } else if (ev->object == pd->min) pd->cur_time[TIMEPICKER_MIN] = efl_ui_range_value_get(pd->min); else { - if (!strcmp(efl_text_get(pd->ampm), "PM")) + if (eina_streq(efl_text_get(pd->ampm), "PM")) { efl_text_set(pd->ampm, "AM"); pd->cur_time[TIMEPICKER_HOUR] -= 12;