From 2d7678074eb050246e0da23df05abd091466e9cc Mon Sep 17 00:00:00 2001 From: Christopher Michael Date: Thu, 14 Mar 2019 12:36:11 -0400 Subject: [PATCH] efl_canvas_vg_object: Fix dereference after null check Coverity reports that both pname & file variables can be null here, and that we are potentially passing NULL to strcmp. Check for valid variables before passing to strcmp Fixes Coverity CID1399423, CID1399421 @fix Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D8350 --- src/lib/evas/canvas/efl_canvas_vg_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/evas/canvas/efl_canvas_vg_object.c b/src/lib/evas/canvas/efl_canvas_vg_object.c index 9fc2d5e6f8..db8ec4fdf4 100644 --- a/src/lib/evas/canvas/efl_canvas_vg_object.c +++ b/src/lib/evas/canvas/efl_canvas_vg_object.c @@ -257,7 +257,7 @@ _efl_canvas_vg_object_efl_file_file_set(Eo *eo_obj, Efl_Canvas_Vg_Object_Data *p int pl = pname ? strlen(pname) : 0; int cl = file ? strlen(file) : 0; - if ((pl != cl) || strcmp(pname, file)) + if ((pl != cl) || (pname && file && strcmp(pname, file))) { Evas_Object_Protected_Data *obj; obj = efl_data_scope_get(eo_obj, EFL_CANVAS_OBJECT_CLASS);