From 2f17b4c391504ac3f10bc6b41eeaa03701571906 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 31 Oct 2019 09:02:45 -0400 Subject: [PATCH] tests/spec: reduce looping of pack content tests Summary: this was hugely over-testing before; simply verifying one item outside the limit is sufficient here Depends on D10567 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10568 --- src/tests/elementary/spec/efl_test_pack_linear.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/tests/elementary/spec/efl_test_pack_linear.c b/src/tests/elementary/spec/efl_test_pack_linear.c index ad7644206e..3886dfde9b 100644 --- a/src/tests/elementary/spec/efl_test_pack_linear.c +++ b/src/tests/elementary/spec/efl_test_pack_linear.c @@ -367,6 +367,7 @@ EFL_END_TEST EFL_START_TEST(pack_content_get1) { Efl_Ui_Widget *wid[3]; + int num_widgets = EINA_C_ARRAY_LENGTH(wid); for (int i = 0; i < 3; i++) { @@ -374,14 +375,14 @@ EFL_START_TEST(pack_content_get1) efl_pack_end(widget, wid[i]); } - for (int i = -100000; i <= 100000; i++) + for (int i = -num_widgets - 1; i <= num_widgets + 1; i++) { - if (i < -3) + if (i <= -num_widgets) ck_assert_ptr_eq(efl_pack_content_get(widget, i), efl_pack_content_get(widget, 0)); - else if (i >= -3 && i < 3) - ck_assert_ptr_eq(efl_pack_content_get(widget, i), wid[(i + 3) % 3]); - else + else if (i >= num_widgets) ck_assert_ptr_eq(efl_pack_content_get(widget, i), efl_pack_content_get(widget, 2)); + else + ck_assert_ptr_eq(efl_pack_content_get(widget, i), wid[(i + num_widgets) % num_widgets]); } } EFL_END_TEST