kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore_evas_extn: do not update plug image when lockfile is invalid. 

Summary:
This prevent invalid shared memory access.
Invalid access occur when server is resized sequentially from now to A-size
to B-size, and client receive A resize message after resizing B.
Then client try to render plug image with A-size, but shared memory is B-size
buffer. Size are mismatch. This makes segmentation fault when uploading texture(gl)
or rendering image(sw).

Test Plan: Indicator rendering on Tizen3.0 platform.

Reviewers: jypark, wonsik, dkdk, scholb.kim, jiin.moon, jpeg, cedric

Reviewed By: cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4711

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Minkyoung Kim 2017-03-21 11:05:43 -07:00 committed by Cedric BAIL
parent 76b5749ea0
commit 38e6780262
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/modules/ecore_evas/engines/extn/ecore_evas_extn.c
View File

@ -1021,6 +1021,17 @@ _ipc_server_data(void *data, int type EINA_UNUSED, void *event)
{
Ipc_Data_Update *ipc;
int n = e->response;
/* b->lockfd is not enough to ensure the size is same
* between what server knows, and client knows.
* So should check file lock also. */
if (extn->b[n].buf && (!_extnbuf_lock_file_get(extn->b[n].buf)))
{
EINA_LIST_FREE(extn->file.updates, ipc)
{
free(ipc);
}
break;
}
EINA_LIST_FREE(extn->file.updates, ipc)
{