From 3a64b0ccd39c7dbdc2f307ee4098920ac7e14a9e Mon Sep 17 00:00:00 2001 From: Srivardhan Hebbar Date: Fri, 27 Mar 2015 18:39:57 +0100 Subject: [PATCH] ecore_con: fix ftp upload function to follow documentation. Summary: While creating a Ecore_con_url object, the url is given in this format "ftp://ftp.example.com". While uploading a file, this function was prefixing "ftp://" to this url which resulted in DNS failure, and upload fail. So corrected the issue. Signed-off-by: Srivardhan Hebbar Reviewers: cedric Reviewed By: cedric Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D2221 Signed-off-by: Cedric BAIL --- src/lib/ecore_con/ecore_con_url.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/ecore_con/ecore_con_url.c b/src/lib/ecore_con/ecore_con_url.c index 18fd566e56..05b9d05a71 100644 --- a/src/lib/ecore_con/ecore_con_url.c +++ b/src/lib/ecore_con/ecore_con_url.c @@ -933,10 +933,10 @@ ecore_con_url_ftp_upload(Ecore_Con_Url *url_obj, const char *filename, const cha snprintf(tmp, PATH_MAX, "%s", filename); if (upload_dir) - snprintf(url, sizeof(url), "ftp://%s/%s/%s", url_con->url, + snprintf(url, sizeof(url), "%s/%s/%s", url_con->url, upload_dir, basename(tmp)); else - snprintf(url, sizeof(url), "ftp://%s/%s", url_con->url, + snprintf(url, sizeof(url), "%s/%s", url_con->url, basename(tmp)); if (!ecore_con_url_url_set(url_obj, url))