kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Elm: DragNDrop: Don't check extensions on drags 

Patch from 장효영 (Hyoyoung Chang).  Basically checking extensions is silly,
      and some real life use shows it just breaks things.  Especially since we
      aren't liberal enough with the extensions we check.

I also cleaned up some whitespace and weird indentation at the edges.

SVN revision: 58229
This commit is contained in:
Brett Nash 2011-03-31 12:29:20 +00:00
parent 1a1a04685d
commit 3c51f2f14c
1 changed files with 8 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
legacy/elementary/src/lib/elm_cnp_helper.c
View File

@ -752,7 +752,7 @@ notify_handler_uri(Cnp_Selection *sel, Ecore_X_Event_Selection_Notify *notify)
Ecore_X_Selection_Data *data;
Ecore_X_Selection_Data_Files *files;
Paste_Image *pi;
char *p, *pp, *ext;
char *p, *pp;
data = notify->data;
cnp_debug("data->format is %d %p %p\n", data->format, notify, data);
@ -768,7 +768,11 @@ notify_handler_uri(Cnp_Selection *sel, Ecore_X_Event_Selection_Notify *notify)
}
p = files->files[0];
}
else p = (char *)data->data;
else
{
p = (char *)data->data;
}
if (!p)
{
cnp_debug("Couldn't find a file\n");
@ -780,29 +784,9 @@ notify_handler_uri(Cnp_Selection *sel, Ecore_X_Event_Selection_Notify *notify)
/* Try and continue if it looks sane */
if (*p != '/') return 0;
}
else p += strlen("file://");
ext = p + strlen(p);
if (ext)
else
{
Eina_Bool extok = EINA_FALSE;
int i;
for (i = 0; image_extensions[i]; i++)
{
pp = ext - strlen(image_extensions[i]);
if ((pp >= p) && (!strcasecmp(pp, image_extensions[i])))
{
extok = EINA_TRUE;
break;
}
}
if (!extok)
{
cnp_debug("No known image format extension, ignoring\n");
if (savedtypes.textreq) savedtypes.textreq = 0;
return 0;
}
p += strlen("file://");
}
if (savedtypes.pi) pasteimage_free(savedtypes.pi);