kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

evas - generic loaders - fix possible string overflow on decoders 

fixes CID 1039580
This commit is contained in:
Carsten Haitzler 2014-09-01 18:23:56 +09:00
parent 056c54ebc9
commit 3c5412f728
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/evas/loaders/generic/evas_image_load_generic.c
View File

@ -151,18 +151,21 @@ _load(Eina_File *ef, const char *key,
// double extn not too long // double extn not too long
if (((end - dot2) <= 10) && (!illegal_char(dot2))) if (((end - dot2) <= 10) && (!illegal_char(dot2)))
{ {
strcpy(&(decoders[decoders_num][0]), img_loader); strncpy(&(decoders[decoders_num][0]), img_loader, 127);
decoders[decoders_num][127] = 0;
dotcat(&(decoders[decoders_num][0]), dot2); dotcat(&(decoders[decoders_num][0]), dot2);
decoders_num++; decoders_num++;
} }
// single extn not too long // single extn not too long
if (((end - dot1) <= 5) && (!illegal_char(dot1))) if (((end - dot1) <= 5) && (!illegal_char(dot1)))
{ {
strcpy(&(decoders[decoders_num][0]), img_loader); strncpy(&(decoders[decoders_num][0]), img_loader, 127);
decoders[decoders_num][127] = 0;
dotcat(&(decoders[decoders_num][0]), dot1); dotcat(&(decoders[decoders_num][0]), dot1);
decoders_num++; decoders_num++;
} }
strcpy(decoders[decoders_num], img_loader); strncpy(decoders[decoders_num], img_loader, 127);
decoders[decoders_num][127] = 0;
decoders_num++; decoders_num++;
} }
else if (dot1) else if (dot1)
@ -174,12 +177,14 @@ _load(Eina_File *ef, const char *key,
dotcat(&(decoders[decoders_num][0]), dot1); dotcat(&(decoders[decoders_num][0]), dot1);
decoders_num++; decoders_num++;
} }
strcpy(decoders[decoders_num], img_loader); strncpy(decoders[decoders_num], img_loader, 127);
decoders[decoders_num][127] = 0;
decoders_num++; decoders_num++;
} }
else else
{ {
strcpy(decoders[decoders_num], img_loader); strncpy(decoders[decoders_num], img_loader, 127);
decoders[decoders_num][127] = 0;
decoders_num++; decoders_num++;
} }