kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eina_module: Drop ridiculous ERR messages from module_list_load/unload 

The documentation for these functions claims that passing a NULL array
results in doing nothing - that should also include logging nothing.

EINA_SAFETY_ON_NULL_RETURN() logs an ERR message and should be reserved
for usage when NULL is not actually a valid state.

Additionally, it's entirely possible to turn off EINA_SAFETY_CHECKS, at
which point these functions would stop behaving as the documentation
says they do.  Not great.
This commit is contained in:
Derek Foreman 2018-01-26 14:29:03 -06:00
parent 01aac084d7
commit 3e230693e6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/eina/eina_module.c
View File

@ -565,7 +565,7 @@ EAPI void eina_module_list_load(Eina_Array *array)
Eina_Module *m;
unsigned int i;
EINA_SAFETY_ON_NULL_RETURN(array);
if (!array) return;
DBG("array %p, count %u", array, array->count);
EINA_ARRAY_ITER_NEXT(array, i, m, iterator)
{
@ -580,7 +580,7 @@ EAPI void eina_module_list_unload(Eina_Array *array)
Eina_Module *m;
unsigned int i;
EINA_SAFETY_ON_NULL_RETURN(array);
if (!array) return;
DBG("array %p, count %u", array, array->count);
EINA_ARRAY_ITER_NEXT(array, i, m, iterator)
eina_module_unload(m);