kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm cnp: fix freeing selection buf 

Moved a misplaced ELM_SAFE_FREE of the selection buffer,
 as valgrind still showed lost bytes with selection.
This commit is contained in:
Daniel Hirt 2014-02-04 15:02:54 +02:00 committed by Daniel Zaoui
parent 431b15cd48
commit 41b6a932fe
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/src/lib/elm_cnp.c
View File

@ -1752,12 +1752,12 @@ _x11_elm_cnp_selection_set(Ecore_X_Window xwin, Evas_Object *obj, Elm_Sel_Type s
evas_object_event_callback_add
(sel->widget, EVAS_CALLBACK_DEL, _x11_sel_obj_del, sel);
ELM_SAFE_FREE(sel->selbuf, free);
if (selbuf)
{
if (format == ELM_SEL_FORMAT_IMAGE)
{
// selbuf is actual image data, not text/string
ELM_SAFE_FREE(sel->selbuf, free);
sel->selbuf = malloc(buflen + 1);
if (!sel->selbuf)
{
@ -1770,8 +1770,6 @@ _x11_elm_cnp_selection_set(Ecore_X_Window xwin, Evas_Object *obj, Elm_Sel_Type s
else
sel->selbuf = strdup((char*)selbuf);
}
else
sel->selbuf = NULL;
return EINA_TRUE;
}