kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm_entry: Cursor disappears on calling select function in an empty entry. 

Summary:
Issue: Selection cannot happen on an empty entry, if selection functions
are called on empty entry, cursor is hidden, even if entry is focused.
Soln: Check for whether entry is empty or not before proceeding with selection.

Test Plan:
1. Call select_all, select_region_set on a focused entry
2. You can observe cursor cannot be seen.

Reviewers: jpeg

Reviewed By: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4862
This commit is contained in:
Shilpa Singh 2017-05-12 15:10:37 +09:00 committed by Jean-Philippe Andre
parent ef2f37cad1
commit 442ab2bc67
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/elementary/elm_entry.c
View File

@ -4286,8 +4286,9 @@ _elm_entry_select_none(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd)
}
EOLIAN static void
_elm_entry_select_all(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd)
_elm_entry_select_all(Eo *obj, Elm_Entry_Data *sd)
{
if (elm_entry_is_empty(obj)) return;
if ((sd->password)) return;
if (sd->sel_mode)
{
@ -4301,8 +4302,9 @@ _elm_entry_select_all(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd)
}
EOLIAN static void
_elm_entry_select_region_set(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd, int start, int end)
_elm_entry_select_region_set(Eo *obj, Elm_Entry_Data *sd, int start, int end)
{
if (elm_entry_is_empty(obj)) return;
if ((sd->password)) return;
if (sd->sel_mode)
{