kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore-drm2: Add missing EINA_SAFETY checks for public facing API 

functions

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2016-09-09 15:05:00 -04:00
parent 95bb942aa7
commit 50aa37790f
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/ecore_drm2/ecore_drm2_fb.c
View File

@ -224,7 +224,8 @@ ecore_drm2_fb_dirty(Ecore_Drm2_Fb *fb, Eina_Rectangle *rects, unsigned int count
#endif #endif
} }
static void _release_buffer(Ecore_Drm2_Output *output, Ecore_Drm2_Fb *b) static void
_release_buffer(Ecore_Drm2_Output *output, Ecore_Drm2_Fb *b)
{ {
b->busy = EINA_FALSE; b->busy = EINA_FALSE;
if (output->release_cb) output->release_cb(output->release_data, b); if (output->release_cb) output->release_cb(output->release_data, b);
@ -233,6 +234,8 @@ static void _release_buffer(Ecore_Drm2_Output *output, Ecore_Drm2_Fb *b)
EAPI Eina_Bool EAPI Eina_Bool
ecore_drm2_fb_flip_complete(Ecore_Drm2_Output *output) ecore_drm2_fb_flip_complete(Ecore_Drm2_Output *output)
{ {
EINA_SAFETY_ON_NULL_RETURN_VAL(output, EINA_FALSE);
if (output->current && (output->current != output->pending)) if (output->current && (output->current != output->pending))
_release_buffer(output, output->current); _release_buffer(output, output->current);
output->current = output->pending; output->current = output->pending;
@ -319,18 +322,22 @@ ecore_drm2_fb_flip(Ecore_Drm2_Fb *fb, Ecore_Drm2_Output *output)
EAPI Eina_Bool EAPI Eina_Bool
ecore_drm2_fb_busy_get(Ecore_Drm2_Fb *fb) ecore_drm2_fb_busy_get(Ecore_Drm2_Fb *fb)
{ {
EINA_SAFETY_ON_NULL_RETURN_VAL(fb, EINA_FALSE);
return fb->busy; return fb->busy;
} }
EAPI void EAPI void
ecore_drm2_fb_busy_set(Ecore_Drm2_Fb *fb, Eina_Bool busy) ecore_drm2_fb_busy_set(Ecore_Drm2_Fb *fb, Eina_Bool busy)
{ {
EINA_SAFETY_ON_NULL_RETURN(fb);
fb->busy = busy; fb->busy = busy;
} }
EAPI void EAPI void
ecore_drm2_output_fb_release(Ecore_Drm2_Output *o) ecore_drm2_output_fb_release(Ecore_Drm2_Output *o)
{ {
EINA_SAFETY_ON_NULL_RETURN(o);
if (o->next) if (o->next)
{ {
_release_buffer(o, o->next); _release_buffer(o, o->next);
@ -358,7 +365,8 @@ ecore_drm2_output_fb_release(Ecore_Drm2_Output *o)
} }
EAPI void * EAPI void *
ecore_drm2_fb_bo_get(Ecore_Drm2_Fb *f) ecore_drm2_fb_bo_get(Ecore_Drm2_Fb *fb)
{ {
return f->gbm_bo; EINA_SAFETY_ON_NULL_RETURN_VAL(fb, NULL);
return fb->gbm_bo;
} }

4
src/lib/ecore_drm2/ecore_drm2_outputs.c
View File

@ -1200,12 +1200,16 @@ next:
EAPI void EAPI void
ecore_drm2_output_user_data_set(Ecore_Drm2_Output *o, void *data) ecore_drm2_output_user_data_set(Ecore_Drm2_Output *o, void *data)
{ {
EINA_SAFETY_ON_NULL_RETURN(o);
o->user_data = data; o->user_data = data;
} }
EAPI void EAPI void
ecore_drm2_output_release_handler_set(Ecore_Drm2_Output *o, Ecore_Drm2_Release_Handler cb, void *data) ecore_drm2_output_release_handler_set(Ecore_Drm2_Output *o, Ecore_Drm2_Release_Handler cb, void *data)
{ {
EINA_SAFETY_ON_NULL_RETURN(o);
o->release_data = data; o->release_data = data;
o->release_cb = cb; o->release_cb = cb;
} }