From 5cfb0d9b7cf105a367c871868fc7a5b66e0429ac Mon Sep 17 00:00:00 2001 From: Ryuan Choi Date: Tue, 6 Aug 2013 20:08:16 +0900 Subject: [PATCH] fileselector: Simple refactoring to fix possible leak. This fixes "Resource leaks" which was spotted by coverity. CID 1054518 --- legacy/elementary/src/lib/elc_fileselector.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/legacy/elementary/src/lib/elc_fileselector.c b/legacy/elementary/src/lib/elc_fileselector.c index 983f1eb501..6443c04538 100644 --- a/legacy/elementary/src/lib/elc_fileselector.c +++ b/legacy/elementary/src/lib/elc_fileselector.c @@ -667,21 +667,21 @@ _on_item_selected(void *data, if (!path) return; - sdata = malloc(sizeof(*sdata)); - sdata->fs = data; - sdata->path = path; - if (sd->only_folder) eina_stringshare_replace(&sd->path, path); else { - dir = ecore_file_dir_get(sdata->path); + dir = ecore_file_dir_get(path); if (!dir) return; eina_stringshare_replace(&sd->path, dir); free(dir); } + sdata = malloc(sizeof(*sdata)); + sdata->fs = data; + sdata->path = path; + if (sd->sel_idler) { old_sd = ecore_idler_del(sd->sel_idler);