From 60fec61c8bc6a817b317d29b8556bc5b468828bf Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Mon, 8 Aug 2016 17:15:22 +0900 Subject: [PATCH] ecore gl module - dont check value that is already valid make coverity happy with CID 1347410 - it's technically right that the code assumes the im ptr is valid until then as it dereferences it until then and then stores it under pd->image but then checks for NULL.. it would have crashed already if it were, so rmemove the pointless check. --- .../evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c b/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c index 2e34d4edf6..e39f1f1da9 100644 --- a/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c +++ b/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c @@ -48,7 +48,6 @@ _evas_ector_gl_rgbaimage_buffer_evas_ector_buffer_engine_image_set(Eo *obj, Evas pd->evas = eo_xref(evas, obj); evas_cache_image_ref(&im->cache_entry); pd->image = im; - if (!pd->image) return; ector_buffer_pixels_set(obj, im->image.data, im->cache_entry.w, im->cache_entry.h, 0, (Efl_Gfx_Colorspace) im->cache_entry.space, EINA_TRUE, 0, 0, 0, 0); }