From 62e470130c7005e85f5e1c7e039c352f31bad8b3 Mon Sep 17 00:00:00 2001 From: WooHyun Jung Date: Fri, 29 Nov 2019 04:15:48 +0000 Subject: [PATCH] efl_ui_position_manager_grid: avoid zero division case This fixes the issue of zero division when columns is zero. Sometimes columns can be zero when "pd->viewport.w = 0". Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D10768 --- src/lib/elementary/efl_ui_position_manager_grid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elementary/efl_ui_position_manager_grid.c b/src/lib/elementary/efl_ui_position_manager_grid.c index bc3124abdc..7b0ed303f5 100644 --- a/src/lib/elementary/efl_ui_position_manager_grid.c +++ b/src/lib/elementary/efl_ui_position_manager_grid.c @@ -706,6 +706,7 @@ _efl_ui_position_manager_grid_efl_ui_position_manager_entity_position_single_ite EINA_SAFETY_ON_FALSE_RETURN_VAL(group_consumed_ids == 0, EINA_RECT(0, 0, 0, 0)); int columns = pd->viewport.w/pd->max_min_size.w; + if (columns == 0) return EINA_RECT(0, 0, 0, 0); int sub_pos_id = idx - group_consumed_ids; if (pd->dir == EFL_UI_LAYOUT_ORIENTATION_VERTICAL)