kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

multibuttonentry: Item selected callback called twice redundantly. 

Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix

Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.

Reviewers: Hermet, woohyun, JackDanielZ, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D1955
This commit is contained in:
woochan lee 2015-02-14 22:56:05 +09:00 committed by Daniel Juyung Seo
parent aa647b6a2c
commit 684013d25e
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
legacy/elementary/src/lib/elc_multibuttonentry.c
View File

@ -481,16 +481,10 @@ _on_item_clicked(void *data,
if (sd->view_state == MULTIBUTTONENTRY_VIEW_SHRINK)
return;
_current_item_change(WIDGET(it), eo_it);
_item_select(WIDGET(it), it);
if (sd->selected_it)
{
if ((it = sd->selected_it) != NULL)
{
evas_object_smart_callback_call(VIEW(it), SIG_ITEM_CLICKED, eo_it);
_item_select(WIDGET(it), it);
}
}
evas_object_smart_callback_call(VIEW(it), SIG_ITEM_CLICKED, eo_it);
}
static void