kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

slider: fix a potentional crashing problem 

null pointer dereferencing could happen once eina_value_setup fails.
this patch fixes the problem in adavnace

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D12173
This commit is contained in:
Wonki Kim 2020-10-12 02:32:10 +00:00 committed by Christopher Michael
parent 0d9cc0a562
commit 728d4dba16
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/elementary/elm_slider.c
View File

@ -102,7 +102,7 @@ _units_set(Evas_Object *obj)
{
Eina_Value val;
eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE);
if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return;
eina_strbuf_reset(sd->format_strbuf);
if (!sd->intvl_enable)
@ -147,7 +147,7 @@ _indicator_set(Evas_Object *obj)
if (!sd->indi_format_cb) return;
eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE);
if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return;
eina_strbuf_reset(sd->indi_format_strbuf);
eina_value_set(&val, sd->val);
@ -180,7 +180,7 @@ _min_max_set(Evas_Object *obj)
Eina_Value val;
if (!sd->format_cb) return;
eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE);
if (!eina_value_setup(&val, EINA_VALUE_TYPE_DOUBLE)) return;
str = eina_strbuf_new();