kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

From: Kim Shinwoo <kimcinoo.efl@gmail.com> 

Subject: [E-devel] [patch][elementary] ctxpopup - use proper mouse
signal for item

ctxpopup had used its own item not the elm_list. i would like to fix a bug
on selecting item to support user who is using old version ctxpopup.
the reproduce steps are as below.

 0. precondition: ctxpopup displays which has a lot of items, so user
 should scroll to select bottom(or up) side item.
  1. scroll down(or up) ctxpopup item
   2. select one of items
   
   on step 2,
   the item back ground seems to be clicked. it means part "bg" changes its
state to "clicked" when part "over2" emits "mouse,down,1"
and "default" when part "over2" emits "mouse,up,1".

but, part "over1" have used "ignore_flags: ON_HOLD" with "mouse,up,1", so
on step 2, it cannot emit "elm,action,click"
because elm_scroller uses ELM_EVENT_FLAG_ON_HOLD. so user should
select(click) the item once again.

so in the attached patch, it would be better to remove the "ignore_flags:
ON_HOLD" and use "mouse,clicked,1" instead of "mouse,up,1" as others.
then, please review the attached patch and give feedback. thanks.




SVN revision: 77994
This commit is contained in:
Kim Shinwoo 2012-10-15 09:14:23 +00:00 committed by Carsten Haitzler
parent 1b2a42c819
commit 742454c2eb
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
legacy/elementary/data/themes/widgets/ctxpopup.edc
View File

@ -496,7 +496,6 @@ group {
type: RECT;
mouse_events: 1;
repeat_events: 1;
ignore_flags: ON_HOLD;
description { state: "default" 0.0;
color: 255 255 255 0;
}
@ -540,7 +539,7 @@ group {
programs {
program {
name: "item_unclick";
signal: "mouse,up,1";
signal: "mouse,clicked,1";
source: "over1";
action: SIGNAL_EMIT "elm,action,click" "";
}
@ -640,7 +639,6 @@ group {
type: RECT;
mouse_events: 1;
repeat_events: 1;
ignore_flags: ON_HOLD;
description { state: "default" 0.0;
color: 255 255 255 0;
}
@ -684,7 +682,7 @@ group {
programs {
program {
name: "item_unclick";
signal: "mouse,up,1";
signal: "mouse,clicked,1";
source: "over1";
action: SIGNAL_EMIT "elm,action,click" "";
}