kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eo: return an Eina_Value error when a get for a property is not implemented. 

Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7936
This commit is contained in:
Cedric BAIL 2019-02-11 17:39:00 -08:00
parent b23f65291f
commit 770750486c
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lib/eo/eo.c
View File

@ -3660,16 +3660,18 @@ efl_property_reflection_set(Eo *obj_id, const char *property_name, Eina_Value va
EAPI Eina_Value
efl_property_reflection_get(Eo *obj_id, const char *property_name)
{
EO_OBJ_POINTER(obj_id, obj);
Eina_Value r = eina_value_error_init(EINA_ERROR_NOT_IMPLEMENTED);
EO_OBJ_POINTER_GOTO(obj_id, obj, end);
const Efl_Object_Property_Reflection *reflection = _efl_class_reflection_find(obj->klass, property_name);
if (!reflection || !reflection->get) goto end;
if (reflection && reflection->get)
r = reflection->get(obj_id);
return reflection->get(obj_id);
end:
end:
EO_OBJ_DONE(obj_id);
return EINA_VALUE_EMPTY;
return r;
}
EAPI Efl_Class_Type

2
src/tests/eo/suite/eo_test_reflection.c
View File

@ -17,7 +17,7 @@ EFL_START_TEST(eo_test_reflection_invalid)
simple_a_set(simple, 22);
efl_property_reflection_set(simple, "simple_a_asdf", numb_val);
fail_if(efl_property_reflection_get(simple, "simple_a_invalid").type != EINA_VALUE_EMPTY.type);
fail_if(efl_property_reflection_get(simple, "simple_a_invalid").type != EINA_VALUE_TYPE_ERROR);
}
EFL_END_TEST