kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eo: Make sure auto_unref only applies after finalize 

It would be pretty stupid to create an object that dies before it even
gets created. Auto-unref is for parts and should probably not be used
anywhere else :)
This commit is contained in:
Jean-Philippe Andre 2017-11-24 16:15:03 +09:00
parent 8608e8dc70
commit 7e785d936d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/eo/eo.c
View File

@ -621,7 +621,7 @@ err:
{
if (EINA_UNLIKELY(obj->auto_unref != 0))
{
if (!(--obj->auto_unref))
if (obj->finalized && !(--obj->auto_unref))
efl_unref(eo_id);
}
_efl_unref(obj);
@ -680,7 +680,7 @@ _efl_object_call_end(Efl_Object_Op_Call_Data *call)
{
if (EINA_UNLIKELY(call->obj->auto_unref != 0))
{
if (!(--call->obj->auto_unref))
if (call->obj->finalized && !(--call->obj->auto_unref))
efl_unref(call->eo_id);
}
_efl_unref(call->obj);
@ -750,7 +750,7 @@ _efl_object_op_api_id_get(const void *api_func, const Eo *eo_obj, const char *ap
"Unable to resolve op for api func %p for obj=%p (%s)", api_func, eo_obj, efl_class_name_get(eo_obj));
if (EINA_UNLIKELY(obj->auto_unref))
{
if (!(--obj->auto_unref))
if (obj->finalized && !(--obj->auto_unref))
efl_unref(eo_obj);
}
return EFL_NOOP;