kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

emotion: fix triggering condition of fallback module loading 

@fix

Summary:
In emotion_engine_instance_new(), if given module name is wrong or if loding is failed, fallback module loading should be triggered.a (previously, it check just whether name is NULL or not)

In case of T1025, "vlc" was given name. Therefore, fallback was not triggered.

Fixes T1025

Test Plan: enlightenment -> efm -> mouse over multimedia files -> check whether preview is shown properly or not

Reviewers: raster, cedric

CC: seoz, cedric, zmike

Maniphest Tasks: T1025

Differential Revision: https://phab.enlightenment.org/D773
This commit is contained in:
Wonguk Jeong 2014-04-20 09:58:47 -04:00 committed by Mike Blumenkrantz
parent 5ab3bd7b7d
commit 80236eed78
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/emotion/emotion_modules.c
View File

@ -356,16 +356,14 @@ emotion_engine_instance_new(const char *name, Evas_Object *obj, Emotion_Module_O
m = _find_mod(name);
if (m) eina_module_load(m);
}
else
if (!_emotion_engine_registry)
{
if (!_emotion_engine_registry)
{
m = _find_mod("generic");
if (!m) m = _find_mod("xine");
if (!m) m = _find_mod("gstreamer");
if (!m) m = _find_mod("gstreamer1");
if (m) eina_module_load(m);
}
m = _find_mod("generic");
if (!m) m = _find_mod("xine");
if (!m) m = _find_mod("gstreamer");
if (!m) m = _find_mod("gstreamer1");
if (m) eina_module_load(m);
}
if (name)