kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Focus: fix segfault due to bad call to Eo function. 

Due to Eolian auto-generation, legacy parameters are directly
transferred to Eo functions without conversion.

In this case, is_next was Eina_Bool in legacy and Eina_Bool * in Eo.
The logic code was expecting a pointer but was receiving a Eina_Bool.

The fix consists in giving the logic code the Eina_Bool instead of the
pointer.

@fix
This commit is contained in:
Daniel Zaoui 2014-03-18 08:07:14 +02:00
parent b4e13220de
commit 8c29f2a77b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/src/lib/elm_genlist.c
View File

@ -7855,13 +7855,13 @@ _elm_genlist_focus_highlight_geometry_get(Eo *obj EINA_UNUSED, void *_pd, va_lis
Evas_Coord *y = va_arg(*list, Evas_Coord *);
Evas_Coord *w = va_arg(*list, Evas_Coord *);
Evas_Coord *h = va_arg(*list, Evas_Coord *);
Eina_Bool *is_next = va_arg(*list, Eina_Bool *);
Eina_Bool is_next = va_arg(*list, int);
Evas_Coord ox, oy, oh, item_x = 0, item_y = 0, item_w = 0, item_h = 0;
Elm_Genlist_Smart_Data *sd = _pd;
evas_object_geometry_get(obj, &ox, &oy, NULL, &oh);
if (is_next && *is_next)
if (is_next)
{
if (sd->focused_item)
{

4
legacy/elementary/src/lib/elm_list.c
View File

@ -3044,11 +3044,11 @@ _elm_list_focus_highlight_geometry_get(Eo *obj EINA_UNUSED, void *_pd, va_list *
Evas_Coord *y = va_arg(*list, Evas_Coord *);
Evas_Coord *w = va_arg(*list, Evas_Coord *);
Evas_Coord *h = va_arg(*list, Evas_Coord *);
Eina_Bool *is_next = va_arg(*list, Eina_Bool *);
Eina_Bool is_next = va_arg(*list, int);
Elm_List_Smart_Data *sd = _pd;
if (is_next && *is_next)
if (is_next)
{
if (sd->focused_item)
{