kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples: js: make sure we declare all variables 

Summary:
Avoiding local variables to be declared global and shared automatically.

Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Reviewers: felipealmeida, zmike

Reviewed By: zmike

Subscribers: zmike, ProhtMeyhet, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10884
This commit is contained in:
Stefan Schmidt 2019-12-24 09:23:22 -05:00 committed by Mike Blumenkrantz
parent f1144705ec
commit 9144e4dae7
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/examples/elementary/button_example_01.js
View File

@ -1,7 +1,7 @@
efl = require('efl');
function setIcon(widget, icon) {
container = widget.part("icon").cast("Efl.Content");
var container = widget.part("icon").cast("Efl.Content");
container.setContent(icon);
}

4
src/examples/elementary/slider_example.js
View File

@ -91,13 +91,13 @@ sl.setVisible(true);
sl.on('changed', function(obj)
{
val = obj.getProgressValue();
var val = obj.getProgressValue();
console.log("Changed to " + val);
});
sl.on('delay_changed', function(obj)
{
val = obj.getProgressValue();
var val = obj.getProgressValue();
console.log("Delay changed to " + val);
});

8
src/examples/elementary/twitter_example_01.js
View File

@ -43,7 +43,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio
if (error)
return;
for(i=0; i < tweets.length; i++){
for(var i=0; i < tweets.length; i++){
var user_name = tweets[i].user.name;
var screen_name = tweets[i].user.screen_name;
var text = tweets[i].text;
@ -58,7 +58,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio
var entry = new efl.Elm.Entry(win);
entry.setPartText("elm.text", text);
entry.setEditable(false);
part = layout.part("tweet_text").cast("Efl.Content");
var part = layout.part("tweet_text").cast("Efl.Content");
part.setContent(entry);
layout.setHintMin(127, 96);
@ -68,7 +68,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio
var icon = new efl.Efl.Ui.Image(win);
icon.fillInside = true;
icon_array.push(icon);
user_icon = layout.part("user_icon").cast("Efl.Content");
var user_icon = layout.part("user_icon").cast("Efl.Content");
user_icon.setContent(icon);
item = tweet_box.packEnd(layout);
layout.setVisible(true);
@ -78,7 +78,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio
var file = fs.createWriteStream(icon_filename);
file.on('finish', function() {
console.log("finished loading the icon file.");
for (i=0; i < icon_array.length; i++) {
for (var i=0; i < icon_array.length; i++) {
icon_array[i].setFile(icon_filename, null);
}
});