kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eina_cxx: Fix eina::value copy constructor. 

Summary:
The previous declaration was causing the implicit copy constructor to be
invoked when copying a new eina::value from an existing eina::value,
thus leading to two wrappers pointing to the same underlying C pointer.

This showed some error messages when running the tests but under autotools
it didn't fail, while building with meson caused it to segfault.

Reviewers: vitor.sousa

Reviewed By: vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7166
This commit is contained in:
Lauro Moura 2018-10-16 18:39:32 -03:00 committed by Vitor Sousa
parent e6fc1ded6e
commit 946b47430d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bindings/cxx/eina_cxx/eina_value.hh
View File

@ -702,7 +702,7 @@ struct value : value_view
* @brief Copy Constructor. Create an generic value storage holding the same value of @p other.
* @param other Another <tt>eina::value</tt> object.
*/
value(value_view const& other)
value(value const& other)
: value_view(_eina_value_traits<char>::create())
{
if(!eina_value_copy(other.native_handle(), _raw))