From 9c9fa4d40187082c4d1361213790aaf678225235 Mon Sep 17 00:00:00 2001 From: Prasoon Singh Date: Thu, 12 Jul 2018 09:19:47 -0400 Subject: [PATCH] elm_spinner: Text button and entry both gets hidden when navigated through arrow keys. Summary: Summary When focus rect move from inc/dec button using keyboard arrow keys, entry show callback is called and focus is set on entry and then text button is hidden. Hiding focus button triggers focus cycle to revert focus on entry, due to which entry gets unfocused callback which subsequently hides entry. So, entry and text button both goes to hidden state. To fix this setting focus on entry after text button is hidden. Signed-Off By: Prasoon Singh Test Plan Move focus rect from inc/dec button to text button, and observe both text button and entry gets invisible. Expected behavior is entry should become active. Test Plan: Move focus rect from inc/dec button to text button, and obesrve both text button and entry gets invivible. Expected behaviour is entry should become active. Reviewers: cedric, CHAN, shilpasingh, zmike Reviewed By: shilpasingh, zmike Subscribers: zmike, #committers, govi, rajeshps, jpeg Tags: #efl Differential Revision: https://phab.enlightenment.org/D5153 --- src/lib/elementary/elm_spinner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_spinner.c b/src/lib/elementary/elm_spinner.c index a2af48b689..fc0b4250e9 100644 --- a/src/lib/elementary/elm_spinner.c +++ b/src/lib/elementary/elm_spinner.c @@ -601,11 +601,11 @@ _entry_show_cb(void *data, ELM_SPINNER_DATA_GET(data, sd); _entry_show(sd); + elm_layout_signal_emit(data, "elm,state,button,inactive", "elm"); + evas_object_hide(sd->text_button); elm_object_focus_set(obj, EINA_TRUE); elm_entry_select_all(obj); sd->entry_visible = EINA_TRUE; - elm_layout_signal_emit(data, "elm,state,button,inactive", "elm"); - evas_object_hide(sd->text_button); } static void