From ad78f2ccf4cab664edf643055273974981b8a79e Mon Sep 17 00:00:00 2001 From: "Godly T.Alias" Date: Thu, 30 May 2019 15:46:27 +0900 Subject: [PATCH] Genlist: Fix for genlist item field update Summary: Avoid unnecessary operations on unrealized item when item field update is called Test Plan: Call item_field_update on an unrealized item Reviewers: cedric, raster, SanghyeonLee Reviewed By: SanghyeonLee Subscribers: #reviewers, rajeev.jnnce, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9019 --- src/lib/elementary/elm_genlist.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index e0c1e7bbb7..39546d5a47 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -7418,6 +7418,13 @@ _elm_genlist_item_fields_update(Eo *eo_item EINA_UNUSED, Elm_Gen_Item *it, if (!it->item->block) return; + if (!it->realized) + { + if (!itf || (itf & ELM_GENLIST_ITEM_FIELD_CONTENT)) + elm_genlist_item_update(eo_item); + return; + } + if ((!itf) || (itf & ELM_GENLIST_ITEM_FIELD_TEXT)) { _item_text_realize(it, VIEW(it), &it->texts, parts);