From ad81ef1364e4035bda527c61c47c2cad193b8e78 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 8 Aug 2018 09:45:30 -0400 Subject: [PATCH] build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites Summary: this needs to be consistent so that it can be used reliably across suites also these build flags really need to be consolidated into a single variable that can be reused Depends on D6666 Reviewers: devilhorns, bu5hm4n Reviewed By: bu5hm4n Subscribers: bu5hm4n, cedric, #committers Tags: #efl_build Differential Revision: https://phab.enlightenment.org/D6731 --- src/Makefile_Cxx.am | 8 +++++--- src/Makefile_Ecore.am | 2 ++ src/Makefile_Ecore_Con.am | 1 + src/Makefile_Eet.am | 1 + src/Makefile_Eeze.am | 1 + src/Makefile_Efl.am | 1 + src/Makefile_Efl_Js.am | 2 +- src/Makefile_Efreet.am | 1 + src/Makefile_Eio.am | 1 + src/Makefile_Eldbus.am | 1 + src/Makefile_Elementary.am | 2 ++ src/Makefile_Elocation.am | 1 + src/Makefile_Elput.am | 1 + src/Makefile_Emile.am | 1 + src/Makefile_Eo.am | 1 + src/Makefile_Eolian.am | 1 + src/Makefile_Eolian_Cxx.am | 2 +- src/Makefile_Eolian_Js.am | 2 +- src/Makefile_Evas.am | 1 + 19 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/Makefile_Cxx.am b/src/Makefile_Cxx.am index 25b0429532..7d38d643dc 100644 --- a/src/Makefile_Cxx.am +++ b/src/Makefile_Cxx.am @@ -234,7 +234,7 @@ tests/eina_cxx/simple.eo.impl.hh tests_eina_cxx_eina_cxx_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eina_cxx\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/eina_cxx\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eina_cxx\" \ -I$(top_builddir)/src/lib/efl \ -I$(top_builddir)/src/lib/efl/interfaces \ @@ -256,7 +256,7 @@ tests/eo_cxx/eo_cxx_suite.h tests_eo_cxx_eo_cxx_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eo_cxx\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/eo_cxx\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eo_cxx\" \ -I$(top_builddir)/src/lib/efl \ -I$(top_builddir)/src/lib/efl/interfaces \ @@ -285,6 +285,7 @@ tests_ecore_cxx_ecore_cxx_suite_CPPFLAGS = \ -I$(top_builddir)/src/lib/efl \ -I$(top_builddir)/src/lib/efl/interfaces \ -I$(top_builddir)/src/lib/ecore \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/ecore_cxx\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/ecore_cxx\" \ @CHECK_CFLAGS@ @ECORE_CXX_CFLAGS@ @EINA_CXX_CFLAGS@ @EVAS_CXX_CFLAGS@ @EINA_CFLAGS@ \ @@ -319,7 +320,7 @@ tests_eet_cxx_eet_cxx_suite_CPPFLAGS = \ -I$(top_builddir)/src/lib/efl \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eet_cxx\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/eet_cxx\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eet_cxx\" \ @EO_CFLAGS@ @CHECK_CFLAGS@ @EET_CXX_CFLAGS@ @EINA_CXX_CFLAGS@ @EET_CFLAGS@ @EINA_CFLAGS@ tests_eet_cxx_eet_cxx_suite_LDADD = @CHECK_LIBS@ @USE_EET_LIBS@ @@ -345,6 +346,7 @@ tests_eldbus_cxx_eldbus_cxx_suite_CPPFLAGS = \ -I$(top_builddir)/src/lib/efl \ -I$(top_builddir)/src/lib/efl/interfaces \ -I$(top_builddir)/src/lib/ecore \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eldbus\" \ @CHECK_CFLAGS@ @ECORE_CXX_CFLAGS@ @EINA_CXX_CFLAGS@ @EINA_CFLAGS@ \ @ECORE_CFLAGS@ @EO_CFLAGS@ @EO_CXX_CFLAGS@ @ELDBUS_CFLAGS@ diff --git a/src/Makefile_Ecore.am b/src/Makefile_Ecore.am index 47b74678a3..8c724fa636 100644 --- a/src/Makefile_Ecore.am +++ b/src/Makefile_Ecore.am @@ -289,6 +289,7 @@ tests/ecore/ecore_test_args.c \ tests/ecore/ecore_suite.h tests_ecore_ecore_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/ecore\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/ecore\" \ @CHECK_CFLAGS@ \ @@ -335,6 +336,7 @@ tests/ecore/efl_app_suite.c \ tests/ecore/efl_app_suite.h tests_ecore_efl_app_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/ecore\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/ecore\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Ecore_Con.am b/src/Makefile_Ecore_Con.am index ca1e80f617..610328a1ef 100644 --- a/src/Makefile_Ecore_Con.am +++ b/src/Makefile_Ecore_Con.am @@ -219,6 +219,7 @@ tests/ecore_con/ecore_con_test_efl_net_ip_address.c \ tests/ecore_con/ecore_con_suite.h tests_ecore_con_ecore_con_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/ecore_con\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/ecore_con\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Eet.am b/src/Makefile_Eet.am index f4e863b158..6724cdb4a5 100644 --- a/src/Makefile_Eet.am +++ b/src/Makefile_Eet.am @@ -76,6 +76,7 @@ tests/eet/eet_test_common.h \ tests/eet/eet_suite.h tests_eet_eet_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eet\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eet\" \ diff --git a/src/Makefile_Eeze.am b/src/Makefile_Eeze.am index 82b96a1470..2e650d8069 100644 --- a/src/Makefile_Eeze.am +++ b/src/Makefile_Eeze.am @@ -180,6 +180,7 @@ tests/eeze/eeze_test_sensor.c \ tests/eeze/eeze_test_udev.c \ tests/eeze/eeze_suite.h tests_eeze_eeze_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ @EEZE_CFLAGS@ \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eeze\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eeze\" \ diff --git a/src/Makefile_Efl.am b/src/Makefile_Efl.am index 2dff54077a..551e907796 100644 --- a/src/Makefile_Efl.am +++ b/src/Makefile_Efl.am @@ -201,6 +201,7 @@ tests/efl/efl_test_model_composite.c \ tests/efl/efl_suite.h tests_efl_efl_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/efl\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/efl\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Efl_Js.am b/src/Makefile_Efl_Js.am index 6f2aa7020b..f4f7ae732e 100644 --- a/src/Makefile_Efl_Js.am +++ b/src/Makefile_Efl_Js.am @@ -200,7 +200,7 @@ SUITE_RUNNER_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -I$(top_srcdir)/src/bindings/js/eo_js \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/efl_js\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/efl_js\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/efl_js\" \ @CHECK_CFLAGS@ \ @EFL_JS_CFLAGS@ \ diff --git a/src/Makefile_Efreet.am b/src/Makefile_Efreet.am index 8912919892..e429273962 100644 --- a/src/Makefile_Efreet.am +++ b/src/Makefile_Efreet.am @@ -231,6 +231,7 @@ tests/efreet/efreet_test_efreet.c \ tests/efreet/efreet_test_efreet_cache.c tests_efreet_efreet_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl $(EFREET_COMMON_CPPFLAGS) @CHECK_CFLAGS@ \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/efreet\" tests_efreet_efreet_suite_LDADD = @CHECK_LIBS@ @USE_EFREET_LIBS@ tests_efreet_efreet_suite_DEPENDENCIES = @USE_EFREET_INTERNAL_LIBS@ diff --git a/src/Makefile_Eio.am b/src/Makefile_Eio.am index 3787636359..6778ad48f7 100644 --- a/src/Makefile_Eio.am +++ b/src/Makefile_Eio.am @@ -89,6 +89,7 @@ tests/eio/eio_test_eet.c \ tests/eio/eio_suite.h tests_eio_eio_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eio\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eio\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Eldbus.am b/src/Makefile_Eldbus.am index 2fd22ad4f5..4e310fc386 100644 --- a/src/Makefile_Eldbus.am +++ b/src/Makefile_Eldbus.am @@ -143,6 +143,7 @@ tests/eldbus/eldbus_fake_server.c \ tests/eldbus/eldbus_suite.h tests_eldbus_eldbus_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl @CHECK_CFLAGS@ @ELDBUS_CFLAGS@ \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ @EFL_CFLAGS@ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eldbus\" tests_eldbus_eldbus_suite_LDADD = @CHECK_LIBS@ @USE_ELDBUS_LIBS@ @USE_EFL_LIBS@ diff --git a/src/Makefile_Elementary.am b/src/Makefile_Elementary.am index ac464f27a5..e1ed314039 100644 --- a/src/Makefile_Elementary.am +++ b/src/Makefile_Elementary.am @@ -1564,6 +1564,7 @@ tests_elementary_elm_suite_SOURCES = \ tests/elementary/elm_test_focus_sub.c tests_elementary_elm_suite_CPPFLAGS = \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"${top_builddir}/src/tests/elementary\" \ -DTESTS_SRC_DIR=\"${top_srcdir}/src/tests/elementary\" \ -DELM_IMAGE_DATA_DIR=\"${top_srcdir}/data/elementary\" \ @@ -1582,6 +1583,7 @@ tests_elementary_efl_ui_suite_SOURCES = \ tests/elementary/efl_ui_suite.c tests_elementary_efl_ui_suite_CPPFLAGS = \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"${top_builddir}/src/tests/elementary\" \ -DTESTS_SRC_DIR=\"${top_srcdir}/src/tests/elementary\" \ -DELM_IMAGE_DATA_DIR=\"${top_srcdir}/data/elementary\" \ diff --git a/src/Makefile_Elocation.am b/src/Makefile_Elocation.am index 82ff192724..292f4738be 100644 --- a/src/Makefile_Elocation.am +++ b/src/Makefile_Elocation.am @@ -33,6 +33,7 @@ if EFL_ENABLE_TESTS #tests/elocation/elocation_suite.c #tests_elocation_elocation_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ #-DTESTS_WD=\"`pwd`\" \ #-DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/elocation\" \ #-DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/elocation\" \ diff --git a/src/Makefile_Elput.am b/src/Makefile_Elput.am index 5997ae6c48..d2b97930ce 100644 --- a/src/Makefile_Elput.am +++ b/src/Makefile_Elput.am @@ -44,6 +44,7 @@ tests/elput/elput_suite.h tests_elput_elput_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -I$(top_srcdir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/elput\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/elput\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Emile.am b/src/Makefile_Emile.am index 5f12b3d8c7..90834cfc3f 100644 --- a/src/Makefile_Emile.am +++ b/src/Makefile_Emile.am @@ -88,6 +88,7 @@ tests/emile/emile_suite.h tests_emile_emile_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -DTESTS_WD=\"`pwd`\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/emile\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/emile\" \ @CHECK_CFLAGS@ \ diff --git a/src/Makefile_Eo.am b/src/Makefile_Eo.am index 7d318d2a5d..43778be897 100644 --- a/src/Makefile_Eo.am +++ b/src/Makefile_Eo.am @@ -152,6 +152,7 @@ tests/eo/suite/eo_test_init.c \ tests/eo/suite/eo_test_lifecycle.c tests_eo_eo_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eo\" \ @CHECK_CFLAGS@ \ @EO_CFLAGS@ \ diff --git a/src/Makefile_Eolian.am b/src/Makefile_Eolian.am index d87f85b936..721c205713 100644 --- a/src/Makefile_Eolian.am +++ b/src/Makefile_Eolian.am @@ -131,6 +131,7 @@ tests/eolian/$(TESTS_EOLIAN_OBJNAME)eolian_suite-eolian_generated_future.$(OBJEX CLEANFILES += tests/eolian/generated_future.eo.h tests/eolian/generated_future.eo.c tests_eolian_eolian_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl -I$(top_builddir)/src/tests/eolian \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eolian\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eolian\" \ -DEO_SRC_DIR=\"$(top_srcdir)/src/lib\" \ diff --git a/src/Makefile_Eolian_Cxx.am b/src/Makefile_Eolian_Cxx.am index 4e2abcedc0..5b0099a33e 100644 --- a/src/Makefile_Eolian_Cxx.am +++ b/src/Makefile_Eolian_Cxx.am @@ -176,7 +176,7 @@ tests_eolian_cxx_eolian_cxx_suite_CXXFLAGS = \ -I$(top_builddir)/src/tests/eolian_cxx \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eolian_cxx\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/eolian_cxx\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DPACKAGE_DATA_DIR=\"$(top_srcdir)/src/tests/eolian_cxx\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eolian_cxx\" \ @CHECK_CFLAGS@ @EOLIAN_CXX_CFLAGS@ @EINA_CXX_CFLAGS@ \ diff --git a/src/Makefile_Eolian_Js.am b/src/Makefile_Eolian_Js.am index 2c31d5621f..7e4e760e25 100644 --- a/src/Makefile_Eolian_Js.am +++ b/src/Makefile_Eolian_Js.am @@ -119,7 +119,7 @@ tests_eolian_js_eolian_js_suite_CPPFLAGS = \ -I$(top_srcdir)/src/tests/efl_js \ -DTESTS_WD=\"`pwd`\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/eolian_js\" \ --DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)/src/tests/eolian_js\" \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DPACKAGE_DATA_DIR=\"$(datadir)/eolian_js\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/eolian_js\" \ @CHECK_CFLAGS@ @EOLIAN_CXX_CFLAGS@ @EINA_JS_CFLAGS@ @EO_JS_CFLAGS@ @EFL_JS_CFLAGS@ \ diff --git a/src/Makefile_Evas.am b/src/Makefile_Evas.am index f882c1edfb..2171c24fc1 100644 --- a/src/Makefile_Evas.am +++ b/src/Makefile_Evas.am @@ -2453,6 +2453,7 @@ tests/evas/evas_suite.h tests_evas_evas_suite_CPPFLAGS = -I$(top_builddir)/src/lib/efl \ -I$(top_srcdir)/src/lib/ecore_evas \ -I$(top_builddir)/src/lib/evas/canvas \ +-DPACKAGE_BUILD_DIR=\"$(abs_top_builddir)\" \ -DTESTS_SRC_DIR=\"$(top_srcdir)/src/tests/evas\" \ -DTESTS_BUILD_DIR=\"$(top_builddir)/src/tests/evas\" \ @CHECK_CFLAGS@ \