From b2a8ef3d1310be74a720e2a8c1bf870741f3f231 Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Fri, 8 Jul 2016 08:46:12 -0400 Subject: [PATCH] evas-wayland-shm: Fix Insecure temporary file Fix using mkstemp directly without securely setting umask first by making use of eina_file_mkstemp function which does set umask. Fixes Coverity CID1357164 @fix Signed-off-by: Chris Michael --- src/modules/evas/engines/wayland_shm/evas_shm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/evas/engines/wayland_shm/evas_shm.c b/src/modules/evas/engines/wayland_shm/evas_shm.c index 2f4fe59245..690d7a67ab 100644 --- a/src/modules/evas/engines/wayland_shm/evas_shm.c +++ b/src/modules/evas/engines/wayland_shm/evas_shm.c @@ -108,8 +108,10 @@ _shm_pool_make(struct wl_shm *shm, int size, void **data) strcat(name, tmp); + fd = eina_file_mkstemp(name, NULL); + if (fd < 0) /* try to create tmp file */ - if ((fd = mkstemp(name)) < 0) + /* if ((fd = mkstemp(name)) < 0) */ { ERR("Could not create temporary file: %m"); free(name);