From b7406df4cf8758f210e511cb1e2d5f591d71e4a0 Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Tue, 8 Nov 2016 11:13:07 -0500 Subject: [PATCH] ecore-evas-wayland: Add warning if we fail to set engine info Coverity reports an error handling issue here as we are not checking the return value of evas_engine_info_set, so check that return and issue a warning if it fails. Fixes Coverity CID1365651 @fix Signed-off-by: Chris Michael --- .../ecore_evas/engines/wayland/ecore_evas_wayland_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c index 705a737d17..4c3efea268 100644 --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c @@ -1922,7 +1922,8 @@ _ee_egl_display_unset(Ecore_Evas *ee) einfo->info.wl_display = NULL; wdata = ee->engine.data; wdata->regen_objs = _evas_canvas_image_data_unset(ecore_evas_get(ee)); - evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo); + if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) + WRN("Failed to set Evas Engine Info for '%s'", ee->driver); } static Eina_Bool