kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eo: preventing infinite loop by safely iterating over children during destructor. 

Differential Revision: https://phab.enlightenment.org/D6078
This commit is contained in:
Cedric BAIL 2018-05-01 14:23:04 -07:00
parent 93893def9f
commit bb66aa37ca
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/eo/eo_base_class.c
View File

@ -2101,7 +2101,8 @@ _efl_object_constructor(Eo *obj, Efl_Object_Data *pd EINA_UNUSED)
EOLIAN static void
_efl_object_destructor(Eo *obj, Efl_Object_Data *pd)
{
Eo *child;
_Eo_Object *obj_child;
Eina_Inlist *l;
Efl_Object_Extension *ext;
_Eo_Object *obj_data2 = NULL;
@ -2165,9 +2166,11 @@ err_parent_back:
return;
children:
while (pd->children)
EINA_INLIST_FOREACH_SAFE(pd->children, l, obj_child)
{
child = _eo_obj_id_get(EINA_INLIST_CONTAINER_GET(pd->children, _Eo_Object));
Eo *child;
child = _eo_obj_id_get(obj_child);
efl_parent_set(child, NULL);
}
goto children_back;