kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eina: comparing unsigned integer with less than zero. 

Summary: Unsigned integer should not be compared less than zero.

Test Plan: NA

Reviewers: cedric

Subscribers: shilpasingh, jpeg

Differential Revision: https://phab.enlightenment.org/D5274

Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
This commit is contained in:
Subodh Kumar 2017-10-13 11:46:28 -07:00 committed by Cedric Bail
parent c47fdb8c80
commit be63db00a7
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/eina/eina_share_common.c
View File

@ -740,7 +740,7 @@ eina_share_common_add_length(Eina_Share *share,
eina_share_common_population_add(share, slen);
if (slen <= 0)
if (slen == 0)
return NULL;
hash = eina_hash_superfast(str, slen);

8
src/lib/eina/eina_strbuf.c
View File

@ -94,7 +94,7 @@ eina_strbuf_append_printf(Eina_Strbuf *buf, const char *fmt, ...)
len = vasprintf(&str, fmt, args);
va_end(args);
if (len <= 0 || !str)
if (len == 0 || !str)
return EINA_FALSE;
ret = eina_strbuf_append_length(buf, str, len);
@ -111,7 +111,7 @@ eina_strbuf_append_vprintf(Eina_Strbuf *buf, const char *fmt, va_list args)
len = vasprintf(&str, fmt, args);
if (len <= 0 || !str)
if (len == 0 || !str)
return EINA_FALSE;
ret = eina_strbuf_append_length(buf, str, len);
@ -131,7 +131,7 @@ eina_strbuf_insert_printf(Eina_Strbuf *buf, const char *fmt, size_t pos, ...)
len = vasprintf(&str, fmt, args);
va_end(args);
if (len <= 0 || !str)
if (len == 0 || !str)
return EINA_FALSE;
ret = eina_strbuf_insert(buf, str, pos);
@ -151,7 +151,7 @@ eina_strbuf_insert_vprintf(Eina_Strbuf *buf,
len = vasprintf(&str, fmt, args);
if (len <= 0 || !str)
if (len == 0 || !str)
return EINA_FALSE;
ret = eina_strbuf_insert(buf, str, pos);