From c5caea03e3b1fabeb53a771cfb03883df1bbfab7 Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Sat, 7 Dec 2013 15:30:52 +0100 Subject: [PATCH] eldbus: on error unref msg This is done on all other errors, EINA_SAFETY macros ain't no silver bullet. Fixes CID 1039177 --- src/lib/eldbus/eldbus_service.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lib/eldbus/eldbus_service.c b/src/lib/eldbus/eldbus_service.c index 4cd8a482e8..693cdf3361 100644 --- a/src/lib/eldbus/eldbus_service.c +++ b/src/lib/eldbus/eldbus_service.c @@ -1026,8 +1026,12 @@ _idler_propschanged(void *data) if (!getter || prop->is_invalidate) continue; - EINA_SAFETY_ON_FALSE_GOTO( - eldbus_message_iter_arguments_append(dict, "{sv}", &entry), error); + if (!eldbus_message_iter_arguments_append(dict, "{sv}", &entry)) + { + eldbus_message_unref(msg); + goto error; + } + eldbus_message_iter_basic_append(entry, 's', prop->property->name); var = eldbus_message_iter_container_new(entry, 'v',