From c8a993d1f77087750518a2684b151870f5e76651 Mon Sep 17 00:00:00 2001 From: Jaehyun Cho Date: Wed, 17 Dec 2014 17:48:51 +0900 Subject: [PATCH] evas - generic loaders - fix possible string overflow on decoders Summary: fix possible string overflow on decoders. this commit is based on commit 3c5412f72879bbce72bfbc7190acd9e5d16d3b46 that fixes CID 1039580. Reviewers: raster Reviewed By: raster Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D1783 --- src/modules/evas/loaders/generic/evas_image_load_generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/evas/loaders/generic/evas_image_load_generic.c b/src/modules/evas/loaders/generic/evas_image_load_generic.c index 22d0acde27..78488d1036 100644 --- a/src/modules/evas/loaders/generic/evas_image_load_generic.c +++ b/src/modules/evas/loaders/generic/evas_image_load_generic.c @@ -173,7 +173,8 @@ _load(Eina_File *ef, const char *key, // single extn not too long if (((end - dot1) <= 5) && (!illegal_char(dot1))) { - strcpy(&(decoders[decoders_num][0]), img_loader); + strncpy(&(decoders[decoders_num][0]), img_loader, 127); + decoders[decoders_num][127] = 0; dotcat(&(decoders[decoders_num][0]), dot1); decoders_num++; }