kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

toolbar: Use snprintf for elm,number,item buffer handling 

Avoid potential buffer overflow

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
This commit is contained in:
Daniel Willmann 2013-03-18 12:07:23 +00:00
parent c88d31d027
commit c9534bab25
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
legacy/elementary/src/lib/elm_toolbar.c
View File

@ -899,7 +899,7 @@ _inform_item_number(Evas_Object *obj)
{
ELM_TOOLBAR_DATA_GET(obj, sd);
Elm_Toolbar_Item *it;
char buf[sizeof("elm,action,click,") + 3];
char buf[sizeof("elm,number,item,") + 4];
static int scount = 0;
int count = 0;
@ -910,7 +910,8 @@ _inform_item_number(Evas_Object *obj)
if (scount != count)
{
scount = count;
sprintf(buf, "elm,number,item,%d", count);
if (snprintf(buf, sizeof(buf), "elm,number,item,%d", count) >= sizeof(buf))
ERR("Too many items to fit signal buffer (%d)", count);
EINA_INLIST_FOREACH(sd->items, it)
{