kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eldbus: connection are destroyed on invalidate, there is no point for any object to not cleanup on invalidate. 

Summary:
This solve a bug when there is a change in order of destruction and you would expect the model to still work.
Depends on D10287

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10288
This commit is contained in:
Cedric BAIL 2019-10-07 10:04:12 -04:00 committed by Mike Blumenkrantz
parent 7f91f6280d
commit d28870daa7
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/eldbus/eldbus_model_arguments.c
View File

@ -76,7 +76,7 @@ _eldbus_model_arguments_custom_constructor(Eo *obj EINA_UNUSED,
}
static void
_eldbus_model_arguments_efl_object_destructor(Eo *obj, Eldbus_Model_Arguments_Data *pd)
_eldbus_model_arguments_efl_object_invalidate(Eo *obj, Eldbus_Model_Arguments_Data *pd)
{
_eldbus_model_arguments_unload(pd);
@ -90,7 +90,7 @@ _eldbus_model_arguments_efl_object_destructor(Eo *obj, Eldbus_Model_Arguments_Da
pd->proxy = NULL;
}
efl_destructor(efl_super(obj, MY_CLASS));
efl_invalidate(efl_super(obj, MY_CLASS));
}
static Eina_Iterator *

2
src/lib/eldbus/eldbus_model_arguments.eo
View File

@ -25,7 +25,7 @@ class @beta Eldbus.Model.Arguments extends Eldbus.Model {
implements {
Efl.Object.constructor;
Efl.Object.finalize;
Efl.Object.destructor;
Efl.Object.invalidate;
Efl.Model.properties { get; }
Efl.Model.property { set; get; }
}

4
src/lib/eldbus/eldbus_model_signal.c
View File

@ -43,11 +43,11 @@ _eldbus_model_signal_signal_constructor(Eo *obj EINA_UNUSED,
}
static void
_eldbus_model_signal_efl_object_destructor(Eo *obj, Eldbus_Model_Signal_Data *pd)
_eldbus_model_signal_efl_object_invalidate(Eo *obj, Eldbus_Model_Signal_Data *pd)
{
_eldbus_model_signal_callback_del(pd);
efl_destructor(efl_super(obj, MY_CLASS));
efl_invalidate(efl_super(obj, MY_CLASS));
}

2
src/lib/eldbus/eldbus_model_signal.eo
View File

@ -14,7 +14,7 @@ class @beta Eldbus.Model.Signal extends Eldbus.Model.Arguments {
}
implements {
Efl.Object.constructor;
Efl.Object.destructor;
Efl.Object.invalidate;
}
constructors {
.signal_constructor;