kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

box: enforce size recalc during unpack_all() 

deleting subobjects here was occurring and triggering sizing eval
prior to removing the objects from the evas box, resulting in a failure
to accurately calculate and set size hints

also set delete_me to block sizing evals during subobj deletion loop
in order to avoid object thrashing during the time when nothing is happening

@fix
This commit is contained in:
Mike Blumenkrantz 2016-01-13 15:43:49 -05:00
parent dfdda0c2ba
commit d28d2c1cdc
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
legacy/elementary/src/lib/elm_box.c
View File

@ -552,12 +552,18 @@ _elm_box_unpack_all(Eo *obj, Elm_Box_Data *_pd EINA_UNUSED)
ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd);
ELM_BOX_CHECK(obj);
ELM_BOX_DATA_GET(obj, sd);
/* set this to block _sizing_eval() calls */
sd->delete_me = EINA_TRUE;
bd = evas_object_smart_data_get(wd->resize_obj);
EINA_LIST_FOREACH (bd->children, l, opt)
elm_widget_sub_object_del(obj, opt->obj);
sd->delete_me = EINA_FALSE;
/* EINA_FALSE means to delete objects as well */
/* EINA_FALSE means do not delete objects */
evas_object_box_remove_all(wd->resize_obj, EINA_FALSE);
/* update size hints */
_sizing_eval(obj);
}
EOLIAN static void