kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf 

Test Plan: compile with `-Wformat-truncation`

Reviewers: raster, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11405
This commit is contained in:
Yeongjong Lee 2020-02-25 12:23:30 +01:00 committed by Xavi Artigas
parent b6bd20a844
commit d8da207f5f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/elementary/test_efl_gfx_vg_value_provider.c
View File

@ -148,7 +148,7 @@ btn_clicked_cb(void *data , const Efl_Event *ev )
char new_path[255], new_type[255], new_values[255];
if (add_value_provider(new_path, new_type, new_values))
{
char buf[255];
char buf[765];
//TODO: Even if there is the same path as the existing item, it is added without updating.
// In efl_ui_vg_animation, duplicate paths are managed.
// However, animator (lottie) does not have an implementation that manages overridden values.
@ -169,7 +169,7 @@ btn_clicked_cb(void *data , const Efl_Event *ev )
}
}
}*/
sprintf(buf, "%s/%s/%s", new_path, new_type, new_values);
snprintf(buf, sizeof(buf), "%s/%s/%s", new_path, new_type, new_values);
list_it = elm_list_item_append(list, buf, NULL, NULL, NULL, NULL);
elm_list_item_bring_in(list_it);
elm_list_go(list);