From dda109a9060d97f2a74de509d2ac538364f6cd03 Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Mon, 18 Feb 2013 12:26:27 +0000 Subject: [PATCH] edbus: Use snprintf to be sure Are dbus function calls with more than 1000 arguments possible? If so -> prevent buffer overflow Signed-off-by: Daniel Willmann --- src/lib/edbus/edbus_message_to_eina_value.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/edbus/edbus_message_to_eina_value.c b/src/lib/edbus/edbus_message_to_eina_value.c index 7601a1d5cc..422f393730 100644 --- a/src/lib/edbus/edbus_message_to_eina_value.c +++ b/src/lib/edbus/edbus_message_to_eina_value.c @@ -282,7 +282,7 @@ _message_iter_struct_to_eina_value(EDBus_Message_Iter *iter) Eina_Value *v; m = calloc(1, sizeof(Eina_Value_Struct_Member)); - sprintf(name, ARG, z); + snprintf(name, 7, ARG, z); m->name = strdup(name); offset = _type_offset(type, offset); m->offset = offset;