kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm_calendar: Improve code quality. 

Summary:
The values(259200, 86400) are hard to know the meaning.
And we don't have to call gmtime() in for loop.

Test Plan: elementary_test -> calendar

Reviewers: jpeg, Hermet, shilpasingh, cedric

Reviewed By: cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4717
This commit is contained in:
Woochan Lee 2017-04-18 10:17:06 +09:00 committed by Jean-Philippe Andre
parent fddbf75fc9
commit e85c92662b
1 changed files with 18 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/lib/elementary/elm_calendar.c
View File

@ -709,40 +709,35 @@ _set_headers(Evas_Object *obj)
{
static char part[] = "ch_0.text";
int i;
struct tm *t;
time_t temp;
ELM_CALENDAR_DATA_GET(obj, sd);
time_t weekday = 259200; /* Just the first sunday since epoch */
elm_layout_freeze(obj);
sd->filling = EINA_TRUE;
if (!sd->weekdays_set)
t = gmtime(&temp);
if (t && !sd->weekdays_set)
{
t->tm_wday = 0;
for (i = 0; i < ELM_DAY_LAST; i++)
{
struct tm *info;
/* I don't know of a better way of doing it */
info = gmtime(&weekday);
if (info)
char *buf;
buf = eina_strftime("%a", t);
if (buf)
{
char *buf;
buf = eina_strftime("%a", info);
if (buf)
{
sd->weekdays[i] = eina_stringshare_add(buf);
free(buf);
}
else
{
/* If we failed getting day, get a default value */
sd->weekdays[i] = _days_abbrev[i];
WRN("Failed getting weekday name for '%s' from locale.",
_days_abbrev[i]);
}
sd->weekdays[i] = eina_stringshare_add(buf);
free(buf);
}
weekday += 86400; /* Advance by a day */
else
{
/* If we failed getting day, get a default value */
sd->weekdays[i] = _days_abbrev[i];
WRN("Failed getting weekday name for '%s' from locale.",
_days_abbrev[i]);
}
t->tm_wday++;
}
}