forked from enlightenment/efl
efl_ui_tab_bar: fix error about double free
Summary: tab is the parent of the icon. so deleting the tab causes deleting the icon automatically. in this case, it can cause double-freed problem once icon has deleted. Test Plan: elementary_test -to efl.ui.tab_pager Reviewers: cedric, Jaehyun_Cho, jpeg Reviewed By: Jaehyun_Cho Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7407
This commit is contained in:
parent
e686199a76
commit
e8827de96d
|
@ -298,7 +298,6 @@ _efl_ui_tab_bar_tab_remove(Eo *obj EINA_UNUSED, Efl_Ui_Tab_Bar_Data *sd, int ind
|
||||||
_tab_unselect(sd, ti);
|
_tab_unselect(sd, ti);
|
||||||
evas_object_box_remove(sd->bx, ti->tab);
|
evas_object_box_remove(sd->bx, ti->tab);
|
||||||
efl_del(ti->tab);
|
efl_del(ti->tab);
|
||||||
efl_del(ti->icon);
|
|
||||||
|
|
||||||
sd->tab_infos = eina_list_remove(sd->tab_infos, ti);
|
sd->tab_infos = eina_list_remove(sd->tab_infos, ti);
|
||||||
sd->cnt --;
|
sd->cnt --;
|
||||||
|
|
Loading…
Reference in New Issue