kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore-evas-extn: Use eina_mkstemp in place of mkstemp 

Summary: This fixes Coverity CID1039610 'calling mkstemp without
securely setting umask first'. Since we have eina_mkstemp which
already handles creating temporary files in the proper directory,
let's use it.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2015-04-20 12:46:48 -04:00
parent 820eca333e
commit ea77578ad6
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c
View File

@ -19,6 +19,7 @@ _extnbuf_new(const char *base, int id, Eina_Bool sys, int num,
char file[PATH_MAX];
mode_t mode = S_IRUSR | S_IWUSR;
int page_size;
Eina_Tmpstr *tmp;
page_size = eina_cpu_page_size();
@ -40,18 +41,7 @@ _extnbuf_new(const char *base, int id, Eina_Bool sys, int num,
if (b->am_owner)
{
const char *s = NULL;
#if defined(HAVE_GETUID) && defined(HAVE_GETEUID)
if (getuid() == geteuid())
#endif
{
s = getenv("XDG_RUNTIME_DIR");
if (!s) s = getenv("TMPDIR");
}
if (!s) s = "/tmp";
snprintf(file, sizeof(file), "%s/ee-lock-XXXXXX", s);
b->lockfd = mkstemp(file);
b->lockfd = eina_file_mkstemp("ee-lock-XXXXXX", &tmp);
if (b->lockfd < 0) goto err;
b->lock = eina_stringshare_add(file);
if (!b->lock) goto err;
@ -69,6 +59,7 @@ _extnbuf_new(const char *base, int id, Eina_Bool sys, int num,
if (b->addr == MAP_FAILED) goto err;
return b;
err:
if (tmp) eina_tmpstr_del(tmp);
_extnbuf_free(b);
return NULL;
}