kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_core_command_line: Fix logically dead code 

Small patch to remove logically dead code. Coverity reports that
execution cannot reach the expression 0U inside this for statement. At
this point in execution, 'array' cannot be NULL, so checking for its
existence is a logically dead check.

Fixes Coverity CID1399106

@fix

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8306
This commit is contained in:
Christopher Michael 2019-03-12 09:41:00 -04:00 committed by Stefan Schmidt
parent 98ca79e8ce
commit ead7f10c09
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/ecore/efl_core_command_line.c
View File

@ -223,7 +223,7 @@ _efl_core_command_line_command_array_set(Eo *obj EINA_UNUSED, Efl_Core_Command_L
eina_stringshare_del(eina_array_pop(pd->command));
eina_array_free(pd->command);
pd->command = NULL;
for (;i < (array ? eina_array_count(array) : 0); ++i)
for (;i < eina_array_count(array); ++i)
{
content = eina_array_data_get(array, i);
eina_stringshare_del(content);