kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_ui_focus_manager_calc: safe if this is root in a flag 

otherwise we would need to get the private data of the focus manager
which is quite a heavy operation. This is slowing down enormously the
visibility setting of widgets.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9617
This commit is contained in:
Marcel Hollerbach 2019-08-19 10:17:50 +02:00
parent c1e6197b21
commit ef858e1bfa
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/elementary/efl_ui_focus_manager_calc.c
View File

@ -69,6 +69,7 @@ struct _Node{
Eina_Bool on_list : 1;
Eina_Bool unused : 1;
Eina_Bool this_is_root : 1;
};
#define T(n) (n->tree)
@ -886,14 +887,13 @@ static void
_free_node(void *data)
{
Node *node = data;
FOCUS_DATA(node->manager);
if (node->type == NODE_TYPE_ONLY_LOGICAL)
efl_event_callback_array_del(node->focusable, logical_node(), node->manager);
else
efl_event_callback_array_del(node->focusable, regular_node(), node->manager);
if (pd->root != data)
if (!node->this_is_root)
{
node_item_free(node);
}
@ -1746,6 +1746,7 @@ _efl_ui_focus_manager_calc_efl_ui_focus_manager_root_set(Eo *obj EINA_UNUSED, Ef
node = _register(obj, pd, root, NULL, NODE_TYPE_ONLY_LOGICAL, NULL);
pd->root = node;
pd->root->this_is_root = 1;
return EINA_TRUE;
}