kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_ui_widget_common: Fix potential resource leak 

Coverity reports that we potentially leak the storage of
'tree_iterator' here because we allocate the space for it, but
potentially juse return due to use of ELM_WIDGET_DATA_GET_OR_RETURN.
To fix this, just move the allocation to after the above macro is
called.

Fixes Coverity CID1399088

@fix

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8314
This commit is contained in:
Christopher Michael 2019-03-12 10:18:17 -04:00 committed by Stefan Schmidt
parent 86cf4e5d7b
commit f60fef6f0f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/elementary/efl_ui_widget_common.c
View File

@ -139,8 +139,8 @@ _only_widget(const void *container EINA_UNUSED, void *data, void *fdata EINA_UNU
EAPI Eina_Iterator*
efl_ui_widget_tree_widget_iterator(Efl_Ui_Widget *obj)
{
Eina_Iterator *tree_iterator = efl_ui_widget_tree_iterator(obj);
ELM_WIDGET_DATA_GET_OR_RETURN(obj, pd, NULL);
Eina_Iterator *tree_iterator = efl_ui_widget_tree_iterator(obj);
return eina_iterator_filter_new(tree_iterator, _only_widget, NULL, NULL);
}